Skip to content

Add ability to save optimizer and resume while training #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 22, 2025
Merged

Add ability to save optimizer and resume while training #275

merged 1 commit into from
Oct 22, 2025

Conversation

@coolkp
Copy link
Collaborator

@coolkp coolkp commented Oct 22, 2025 •
edited
Loading

This pr adds

  1. Add optimizer state to checkpoint (save checkpoint path, whole state saved)
  2. Load optimizer and step, overwrite optimizer in training loop (be careful of shardings) its inherited.
  3. resume training from last checkpointed step

@github-actions
Copy link

github-actions bot commented Oct 22, 2025

e2e testgrid: https://8bcf50593faf4ea38060e236169827e5-dot-us-central1.composer.googleusercontent.com/dags/maxdiffusion_tpu_e2e/grid

@coolkp coolkp merged commit 662d501 into main Oct 22, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@entrpn entrpn entrpn approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@coolkp @entrpn